-
Notifications
You must be signed in to change notification settings - Fork 381
describe ABORTED as error message for CreateVolumeGroupSnapshot #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
describe ABORTED as error message for CreateVolumeGroupSnapshot #563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per @bswartz --
- "Not clear what expected behavior if GroupSnapshot for volume A, B, C pending and another one for group B, C, D is triggered"
- "Probably ok if there are 2 overlapping group snapshots and SP decided to return ABORTED for 2nd snapshot and let you retry." So it's probably ok not to explicitly mention this case.
Per @xing-yang: "Specified group snapshot, could mean all parameters have to be the same".
Next step:
- Let's clarify what "specified group snapshot" means.
Also, @nixpanic, please make sure you've signed the CLA. |
If there is a conflict with the volumes that are part of the group snapshot that should be created, the
Yes, that is more suitable. This
I've rephrased specified group snapshot to group snapshot with the exact same parameters and similar.
This was completed with a group approval for IBM employees, sent by Brad Topol in the beginning of the month 🥳 |
Just like ABORTED is an error for the CreateSnapshot procedure, it should be documented for CreateVolumeGroupSnapshot.
2ab7acf
to
9ea4e2c
Compare
Oh, this old change fell off my radar. @xing-yang are you on board with this additional error? |
@bswartz This looks good to me. |
What type of PR is this?
Documentation enhancement for a common CreateVolumeGroupSnapshot error.
What this PR does / why we need it:
The
ABORTED
error code is currently not documented for CreateVolumeGroupSnapshot but is explained for CreateSnapshot.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce an API-breaking change?: